hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5600) Add a parameter to ContainerLaunchContext to emulate yarn.nodemanager.delete.debug-delay-sec on a per-application basis
Date Thu, 10 Nov 2016 06:11:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653151#comment-15653151
] 

Miklos Szegedi commented on YARN-5600:
--------------------------------------

Thank you, for the useful comments [~templedf]!
I fixed most of the requests, I have just a few comments:
"I'd rather see you divide by 1000 and add 1. It's a little less clever/more obvious."
Unfortunately, it does not give the same results. It will add an unnecessary second, when
the number is dividable by 1000 and that is not what I need.
"In TestContainerManager, verifyContainerDir() and verifyAppDir() have a lot of common code.
Maybe pull it out into another method?"
There are sporadic differences that make it difficult to be one single function. They used
to be one function and I changed it because I think this is still more readable this way.
"In waitForApplicationDirDeleted() you might be better off with monotonic time."
Can you be more specific?

> Add a parameter to ContainerLaunchContext to emulate yarn.nodemanager.delete.debug-delay-sec
on a per-application basis
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5600
>                 URL: https://issues.apache.org/jira/browse/YARN-5600
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Daniel Templeton
>            Assignee: Miklos Szegedi
>              Labels: oct16-medium
>         Attachments: YARN-5600.000.patch, YARN-5600.001.patch, YARN-5600.002.patch, YARN-5600.003.patch,
YARN-5600.004.patch
>
>
> To make debugging application launch failures simpler, I'd like to add a parameter to
the CLC to allow an application owner to request delayed deletion of the application's launch
artifacts.
> This JIRA solves largely the same problem as YARN-5599, but for cases where ATS is not
in use, e.g. branch-2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message