hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
Date Sun, 27 Nov 2016 09:58:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15699409#comment-15699409
] 

Naganarasimha G R commented on YARN-5572:
-----------------------------------------

Thanks [~varun_saxena], for working on the patch, *HBaseTimelineWriterImpl* is created through
reflection and initialized by the configuration object later 
{code}
  public void serviceInit(Configuration conf) throws Exception {
    writer = ReflectionUtils.newInstance(conf.getClass(
        YarnConfiguration.TIMELINE_SERVICE_WRITER_CLASS,
        HBaseTimelineWriterImpl.class,
        TimelineWriter.class), conf);
    writer.init(conf);
...
}
{code}
hence i do not see the need for the constructor. Will commit the patch shortly.


> HBaseTimelineWriterImpl appears to reference a bad property name
> ----------------------------------------------------------------
>
>                 Key: YARN-5572
>                 URL: https://issues.apache.org/jira/browse/YARN-5572
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Daniel Templeton
>            Assignee: Varun Saxena
>         Attachments: YARN-5572.01.patch
>
>
> This constructor:
> {code}
>   public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
>     super(conf.get("yarn.application.id",
>         HBaseTimelineWriterImpl.class.getName()));
>   }
> {code}
> references "yarn.application.id", which is the only reference to this property I could
find.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message