hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue
Date Tue, 29 Nov 2016 22:06:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706689#comment-15706689
] 

Daniel Templeton commented on YARN-5554:
----------------------------------------

Thanks for all the patch updates, [~wilfreds].  My turn. ;)

* " doesn't have permissions submit to target queue: " is missing a "to" before the "submit."
* In {{QueueACLsManager.checkAccess()}}, I don't see why you need to do the scheduler-dependent
_if_.  Can't you just call {{checkAccess()}} in all cases?
* In your tests, I would feel better if you tested that the app is in the right queue after
the successful moves.
* Note that your use of a lambda in {{createClientRMServiceForMoveApplicationRequest()}} means
this patch can only go into trunk.

> MoveApplicationAcrossQueues does not check user permission on the target queue
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5554
>                 URL: https://issues.apache.org/jira/browse/YARN-5554
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.2
>            Reporter: Haibo Chen
>            Assignee: Wilfred Spiegelenburg
>              Labels: oct16-medium
>         Attachments: YARN-5554.2.patch, YARN-5554.3.patch, YARN-5554.4.patch, YARN-5554.5.patch,
YARN-5554.6.patch, YARN-5554.7.patch, YARN-5554.8.patch, YARN-5554.9.patch
>
>
> moveApplicationAcrossQueues operation currently does not check user permission on the
target queue. This incorrectly allows one user to move his/her own applications to a queue
that the user has no access to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message