hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4395) Typo in comment in ClientServiceDelegate
Date Tue, 29 Nov 2016 23:38:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706932#comment-15706932
] 

Andrew Wang commented on YARN-4395:
-----------------------------------

In the future let's remember to wait for the precommit bot to run. This typo fix looks quite
safe, but having contributors press "Submit Patch" and look at the precommit output helps
them get used to our workflow.

> Typo in comment in ClientServiceDelegate
> ----------------------------------------
>
>                 Key: YARN-4395
>                 URL: https://issues.apache.org/jira/browse/YARN-4395
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Daniel Templeton
>            Assignee: Alison Yu
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 3.0.0-alpha2
>
>         Attachments: YARN-4395.001.patch
>
>
> Line 337 in {{invoke()}} has the following comment:
> {code}
>         // if it's AM shut down, do not decrement maxClientRetry as we wait for
>         // AM to be restarted.
> {code}
> Ideally it should be:
> {code}
>         // If its AM shut down, do not decrement maxClientRetry while we wait
>         // for its AM to be restarted.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message