hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3359) Recover collector list in RM failed over
Date Sat, 05 Nov 2016 19:13:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640396#comment-15640396
] 

Varun Saxena commented on YARN-3359:
------------------------------------

[~gtCarrera9], wouldn't it be better to have code like below ?
If we get from map twice in the if condition, we can still potentially get a NPE even though
the first check is for null
{code}
      Application app = context.getApplications().get(entry.getKey());
      if (app != null && !ApplicationState.FINISHED.equals(
          app.getApplicationState())) {
       ........
     } else {
       ........
     }
{code}

> Recover collector list in RM failed over
> ----------------------------------------
>
>                 Key: YARN-3359
>                 URL: https://issues.apache.org/jira/browse/YARN-3359
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Junping Du
>            Assignee: Li Lu
>              Labels: YARN-5355, oct16-medium
>         Attachments: YARN-3359-YARN-5355.001.patch, YARN-3359-YARN-5355.002.patch, YARN-3359-YARN-5355.003.patch,
YARN-3359-YARN-5638.patch
>
>
> Per discussion in YARN-3039, split the recover work from RMStateStore in a separated
JIRA.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message