Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6534E200BB0 for ; Sun, 30 Oct 2016 19:18:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 63E1F160AF1; Sun, 30 Oct 2016 18:18:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 840BE160ADD for ; Sun, 30 Oct 2016 19:17:59 +0100 (CET) Received: (qmail 31732 invoked by uid 500); 30 Oct 2016 18:17:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 31719 invoked by uid 99); 30 Oct 2016 18:17:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Oct 2016 18:17:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7CE982C0D55 for ; Sun, 30 Oct 2016 18:17:58 +0000 (UTC) Date: Sun, 30 Oct 2016 18:17:58 +0000 (UTC) From: "Varun Saxena (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (YARN-5805) Add isDebugEnabled check in ContainersMonitorImpl for debug log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 30 Oct 2016 18:18:00 -0000 [ https://issues.apache.org/jira/browse/YARN-5805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15620346#comment-15620346 ] Varun Saxena edited comment on YARN-5805 at 10/30/16 6:17 PM: -------------------------------------------------------------- [~bibinchundatt], as this is a straightforward change, how about guarding up all LOG.debug statements across nodemanager instead of only this specific class ? We have a few more of them. Only the ones called repeatedly would need change. {noformat} #root:~/Projects/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager$ grep -R "LOG.debug" * | awk -F":" '{print $1}' | sort | uniq -c 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyTokenSecretManager.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/DefaultRequestInterceptor.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java 9 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/PrivilegedOperationExecutor.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsHandlerImpl.java 3 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/ResourceHandlerModule.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TrafficControlBandwidthHandlerImpl.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TrafficController.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DelegatingLinuxContainerRuntime.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/LocalizedResource.java 6 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/security/LocalizerSecurityInfo.java 3 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/security/LocalizerTokenSelector.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/NonAggregatingLogHandler.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/DeletionService.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java 11 src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java 15 src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/scheduler/DistributedScheduler.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/security/NMTokenSecretManagerInNM.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java 12 src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java #root:~/Projects/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager$ grep -R "LOG.isDebug" * | awk -F":" '{print $1}' | sort | uniq -c 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyTokenSecretManager.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/DefaultRequestInterceptor.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/PrivilegedOperationExecutor.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsHandlerImpl.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TrafficControlBandwidthHandlerImpl.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TrafficController.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DelegatingLinuxContainerRuntime.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/LocalizedResource.java 5 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/NonAggregatingLogHandler.java 3 src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/DeletionService.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java 1 src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java 11 src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java 15 src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java 2 src/main/java/org/apache/hadoop/yarn/server/nodemanager/scheduler/DistributedScheduler.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java 4 src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java 12 src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java {noformat} was (Author: varun_saxena): [~bibinchundatt], as this is a straightforward change, how about guarding up all LOG.debug statements across nodemanager instead of only this specific class ? We have a few more of them. Only the ones called repeatedly would need change. > Add isDebugEnabled check in ContainersMonitorImpl for debug log > ----------------------------------------------------------------- > > Key: YARN-5805 > URL: https://issues.apache.org/jira/browse/YARN-5805 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Trivial > Attachments: YARN-5805.0001.patch > > > LOG.debug("Tracking ProcessTree " + pId + " for the first time"); > LOG.debug("Constructing ProcessTree for : PID = " + pId > + " ContainerId = " + containerId); -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org