Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 27 Oct 2016 23:07:58 +0000 (UTC)
From: "Daniel Templeton (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13016001.1477609208000.111482.1477609678526@Atlassian.JIRA>
In-Reply-To: <JIRA.13016001.1477609208000@Atlassian.JIRA>
References: <JIRA.13016001.1477609208000@Atlassian.JIRA> <JIRA.13016001.1477609208815@arcas>
Subject: [jira] [Commented] (YARN-5793) Trim configuration values in
 DockerLinuxContainerRuntime
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 27 Oct 2016 23:08:00 -0000


    [ https://issues.apache.org/jira/browse/YARN-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613588#comment-15613588 ] 

Daniel Templeton commented on YARN-5793:
----------------------------------------

Sorry, I jumped the gun. :)

> Trim configuration values in DockerLinuxContainerRuntime
> --------------------------------------------------------
>
>                 Key: YARN-5793
>                 URL: https://issues.apache.org/jira/browse/YARN-5793
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Tianyin Xu
>            Priority: Minor
>         Attachments: YARN-5793.0000.patch
>
>
> The current implementation of {{DockerLinuxContainerRuntime}} does not follow the practice of trimming configuration values. This leads to errors if users set values containing space or newline.
> see the following YARN commits as reference:
> YARN-3395. FairScheduler: Trim whitespaces when using username for queuename.
> YARN-2869. CapacityScheduler should trim sub queue names when parse configuration.
> YARN-2843. Fixed NodeLabelsManager to trim inputs for hosts and labels so as to make them work correctly.
> and many other Hadoop/HDFS commits (just list a few):
> HDFS-9708. FSNamesystem.initAuditLoggers() doesn't trim classnames
> HDFS-2799. Trim fs.checkpoint.dir values.
> HADOOP-6578. Configuration should trim whitespace around a lot of value types
> HADOOP-6534. Trim whitespace from directory lists initializing
> Patch is available against trunk
> {code:title=DockerLinuxContainerRuntime.java|borderStyle=solid}
> @@ -219,9 +219,9 @@ public void initialize(Configuration conf)
>      dockerClient = new DockerClient(conf);
>      allowedNetworks.clear();
>      allowedNetworks.addAll(Arrays.asList(
> -        conf.getStrings(YarnConfiguration.NM_DOCKER_ALLOWED_CONTAINER_NETWORKS,
> +        conf.getTrimmedStrings(YarnConfiguration.NM_DOCKER_ALLOWED_CONTAINER_NETWORKS,
>              YarnConfiguration.DEFAULT_NM_DOCKER_ALLOWED_CONTAINER_NETWORKS)));
> -    defaultNetwork = conf.get(
> +    defaultNetwork = conf.getTrimmed(
>          YarnConfiguration.NM_DOCKER_DEFAULT_CONTAINER_NETWORK,
>          YarnConfiguration.DEFAULT_NM_DOCKER_DEFAULT_CONTAINER_NETWORK);
>  
> @@ -237,7 +237,7 @@ public void initialize(Configuration conf)
>        throw new ContainerExecutionException(message);
>      }
>  
> -    privilegedContainersAcl = new AccessControlList(conf.get(
> +    privilegedContainersAcl = new AccessControlList(conf.getTrimmed(
>          YarnConfiguration.NM_DOCKER_PRIVILEGED_CONTAINERS_ACL,
>          YarnConfiguration.DEFAULT_NM_DOCKER_PRIVILEGED_CONTAINERS_ACL));
>    }
> @@ -439,7 +439,7 @@ public void launchContainer(ContainerRuntimeContext ctx)
>          LOCALIZED_RESOURCES);
>      @SuppressWarnings("unchecked")
>      List<String> userLocalDirs = ctx.getExecutionAttribute(USER_LOCAL_DIRS);
> -    Set<String> capabilities = new HashSet<>(Arrays.asList(conf.getStrings(
> +    Set<String> capabilities = new HashSet<>(Arrays.asList(conf.getTrimmedStrings(
>          YarnConfiguration.NM_DOCKER_CONTAINER_CAPABILITIES,
>          YarnConfiguration.DEFAULT_NM_DOCKER_CONTAINER_CAPABILITIES)));
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org