Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6D06A200BB3 for ; Wed, 19 Oct 2016 00:48:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6BD3B160AE5; Tue, 18 Oct 2016 22:48:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D6868160AFB for ; Wed, 19 Oct 2016 00:47:59 +0200 (CEST) Received: (qmail 17116 invoked by uid 500); 18 Oct 2016 22:47:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 17091 invoked by uid 99); 18 Oct 2016 22:47:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2016 22:47:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CCB4A2C4C76 for ; Tue, 18 Oct 2016 22:47:58 +0000 (UTC) Date: Tue, 18 Oct 2016 22:47:58 +0000 (UTC) From: "Daniel Templeton (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5047) Refactor nodeUpdate across schedulers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 18 Oct 2016 22:48:00 -0000 [ https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586920#comment-15586920 ] Daniel Templeton commented on YARN-5047: ---------------------------------------- Latest patch looks great. Thanks for doing that refactor. The code is infinitely more readable now. +1 (non-binding) > Refactor nodeUpdate across schedulers > ------------------------------------- > > Key: YARN-5047 > URL: https://issues.apache.org/jira/browse/YARN-5047 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler, fairscheduler, scheduler > Affects Versions: 3.0.0-alpha1 > Reporter: Ray Chiang > Assignee: Ray Chiang > Attachments: YARN-5047.001.patch, YARN-5047.002.patch, YARN-5047.003.patch, YARN-5047.004.patch, YARN-5047.005.patch, YARN-5047.006.patch, YARN-5047.007.patch, YARN-5047.008.patch, YARN-5047.009.patch, YARN-5047.010.patch, YARN-5047.011.patch, YARN-5047.012.patch > > > FairScheduler#nodeUpdate() and CapacityScheduler#nodeUpdate() have a lot of commonality in their code. See about refactoring the common parts into AbstractYARNScheduler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org