Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C98DC200BAE for ; Fri, 28 Oct 2016 23:54:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C869F160AE4; Fri, 28 Oct 2016 21:54:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 25888160ACA for ; Fri, 28 Oct 2016 23:54:00 +0200 (CEST) Received: (qmail 41711 invoked by uid 500); 28 Oct 2016 21:53:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 41668 invoked by uid 99); 28 Oct 2016 21:53:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Oct 2016 21:53:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AF8422C2A66 for ; Fri, 28 Oct 2016 21:53:58 +0000 (UTC) Date: Fri, 28 Oct 2016 21:53:58 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (YARN-3748) Fix volatile variable modification in the scheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 28 Oct 2016 21:54:02 -0000 [ https://issues.apache.org/jira/browse/YARN-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wangda Tan resolved YARN-3748. ------------------------------ Resolution: Won't Fix Really apologize that I missed this JIRA before. Discussed this issue with [~subru] / [~chris.douglas]. First we have already suppressed these findbugs warnings. And also, most of these volatiles are updated by single thread and could be read by multiple threads. So it is not necessary to use Atomic-. In addition, child tasks of YARN-3091 solved a lot of locking related issues/enhancements. So I think this patch is not required, closing it now. Thanks [~gliptak] for reporting and working on this issue and thanks [~busbey] for reviewing it. Please let me know if you have any comments. > Fix volatile variable modification in the scheduler > --------------------------------------------------- > > Key: YARN-3748 > URL: https://issues.apache.org/jira/browse/YARN-3748 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler, resourcemanager > Reporter: Gabor Liptak > Assignee: Gabor Liptak > Priority: Critical > Labels: oct16-easy > Attachments: YARN-3748.1.patch, YARN-3748.2.patch, YARN-3748.3.patch, YARN-3748.5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org