hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5799) Fix OpportunisticAllocation to set the correct value of Node Http Address
Date Sat, 29 Oct 2016 00:17:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617029#comment-15617029
] 

Subru Krishnan commented on YARN-5799:
--------------------------------------

The patch LGTM. +1 (pending Yetus).

I have a couple of minor comments:
  * We should move _convertTo/FromProtoFormat_ to {{RemoteNodePBImpl}} instead of multiple
places, in {{DistributedSchedulingAllocateResponsePBImpl}} & {{RegisterDistributedSchedulingAMResponsePBImpl}}.
  * Please add visibility annotations in {{RemoteNodePBImpl}} and for getters/setters in {{RemoteNode}}.

> Fix OpportunisticAllocation to set the correct value of Node Http Address 
> --------------------------------------------------------------------------
>
>                 Key: YARN-5799
>                 URL: https://issues.apache.org/jira/browse/YARN-5799
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5799.001.patch
>
>
> This proposes to fix the the OpportunisticAllocator, used to allocate OPPORTUNISTIC containers
(both Centrally as well as in a Distributed manner) to correctly populate the Node Http Address
in the returned Container.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message