hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5708) Implement APIs to get resource profiles from the RM
Date Wed, 12 Oct 2016 12:55:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568630#comment-15568630
] 

Arun Suresh commented on YARN-5708:
-----------------------------------

Went over the patch. Thanks [~vvasudev],

# Think we can use some javadocs for some of the abstract classes like {{ProfileCapability}}
# Cross-posting comment I had with YARN-5587:

One thing I did notice when skimming over the patch is that we should probably have a more
consistent way for implementing hashcode/equals and toString in our PB classes.
We have a bunch of places where the hashcode/equals/toString are implemented in the abstract
class (for eg. {{ResourceRequest}}) and there are places where it is defined in the subclass
(for eg. {{ResourceLocalizationRequestPBImpl}}).
I tend to prefer the latter since it is reverts to the proto/builders implementation, which
is (can be) auto-generated and something I would trust to be correct. The former is hand-coded
and error prone.




> Implement APIs to get resource profiles from the RM
> ---------------------------------------------------
>
>                 Key: YARN-5708
>                 URL: https://issues.apache.org/jira/browse/YARN-5708
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-5708-YARN-3926.001.patch, YARN-5708-YARN-3926.002.patch
>
>
> Implement a set of APIs to get the available resource profiles from the RM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message