hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5713) Update jackson from 1.9.13 to 2.x in hadoop-yarn
Date Thu, 27 Oct 2016 23:22:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613629#comment-15613629
] 

Miklos Szegedi commented on YARN-5713:
--------------------------------------

Thank you for the patch [~ajisakaa]!
Overall the change looks good to me. Please see my comments below:
FileSystemTimelineReaderImpl.java has a new newline at the end that is not needed.
JsonSerDeser.java: toJson may throw IOException but does not document it. This is not related
to your change but since you already changed the comment, I thought I will mention it.
TestAHSWebServices ran nicely to me, when I applied the patch to the latest trunk.

> Update jackson from 1.9.13 to 2.x in hadoop-yarn
> ------------------------------------------------
>
>                 Key: YARN-5713
>                 URL: https://issues.apache.org/jira/browse/YARN-5713
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: build, timelineserver
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>              Labels: oct16-medium
>         Attachments: HADOOP-13677.01.patch, HADOOP-13677.02.patch
>
>
> Sub-task of HADOOP-13332.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message