hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Kanter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5466) DefaultContainerExecutor needs JavaDocs
Date Sat, 08 Oct 2016 01:00:40 GMT

    [ https://issues.apache.org/jira/browse/YARN-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556822#comment-15556822
] 

Robert Kanter commented on YARN-5466:
-------------------------------------

A few things (this would be so much easier if we used something like reviewboard):
# {quote}Default constructor to allow for creation via reflection.{quote} Why only reflection?
 It looks like a number of tests call this constructor directly.  I'd just drop the "via reflection"
part.
# {quote}@param script the path make executable{quote} "the path *to* make executable"
# There's a few places that say "Ignored except in secure Windows clusters".  That's kind
of a double-negative.  It might be more clear to say "Only used in secure Windows clusters"
instead, but I'll leave that up to you.
# The argument for the current working directory in {{buildCommandExecutor}} is called {{wordDir}}
in both the code and javadoc.  May as well fix the typo while we're here ({{workDir}}).
# {quote}   \* @param signal signal to send
   \* (for logging).{quote} Unnecessary new line.
# {{createUserLocalDirs}}, {{createUserCacheDirs}}, {{createAppDirs}}, {{createAppLogDirs}},
and {{createContainerLogDirs}} are all missing {{\@throws}}

> DefaultContainerExecutor needs JavaDocs
> ---------------------------------------
>
>                 Key: YARN-5466
>                 URL: https://issues.apache.org/jira/browse/YARN-5466
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.8.0
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Minor
>         Attachments: YARN-5466.001.patch, YARN-5466.002.patch
>
>
> Following on YARN-5455, let's document the DefaultContainerExecutor as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message