hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4907) Make all MockRM#waitForState consistent.
Date Tue, 25 Oct 2016 22:52:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606716#comment-15606716
] 

Miklos Szegedi commented on YARN-4907:
--------------------------------------

+1 (non-binding) I verified and it looks good to me. Thank you, [~yufeigu]!

You might want to change the wait logic in BaseContainerManagerTest.waitForNMContainerState
as well.

> Make all MockRM#waitForState consistent. 
> -----------------------------------------
>
>                 Key: YARN-4907
>                 URL: https://issues.apache.org/jira/browse/YARN-4907
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-4907.001.patch
>
>
> There are some inconsistencies among these {{waitForState}} in {{MockRM}}:
> 1. Some {{waitForState}} return a boolean while others don't.  
> 2. Some {{waitForState}} don't have a timeout, they can wait for ever. 
> 3. Some {{waitForState}} use LOG.info and others use {{System.out.println}} to print
messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message