hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Vasudev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4597) Add SCHEDULE to NM container lifecycle
Date Thu, 13 Oct 2016 13:48:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571974#comment-15571974
] 

Varun Vasudev commented on YARN-4597:
-------------------------------------

Thanks for the patch [~asuresh]. 

1)
I agree with [~kasha] on {quote}The methods for killing containers as needed all seem to be
hardcoded to only consider allocated resources. Can we abstract it out further to allow for
passing either allocation or utilization based on whether oversubscription is enabled.{quote}
At some point, people will want to be able to plug in policies to decide which containers
to kill. However, I wouldn't hold up the patch for it.

2)
The changes to BaseContainerManagerTest.java seem unnecessary.

3)
Can you explain why we need the synchronized block here - {code} +    synchronized (this.containersAllocation)
{code}


> Add SCHEDULE to NM container lifecycle
> --------------------------------------
>
>                 Key: YARN-4597
>                 URL: https://issues.apache.org/jira/browse/YARN-4597
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Chris Douglas
>            Assignee: Arun Suresh
>         Attachments: YARN-4597.001.patch, YARN-4597.002.patch
>
>
> Currently, the NM immediately launches containers after resource localization. Several
features could be more cleanly implemented if the NM included a separate stage for reserving
resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message