hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-5575) Many classes use bare yarn. properties instead of the defined constants
Date Wed, 19 Oct 2016 21:02:58 GMT

     [ https://issues.apache.org/jira/browse/YARN-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Daniel Templeton updated YARN-5575:
    Attachment: YARN-5575.002.patch

Thanks for the review, [~miklos.szegedi@cloudera.com].

The split lines in your first comment are split only because of line length.  There's no particular
convention to splitting a property access.  We fit it on one line if we can, and split it
if we can't.

Good catch on the duplicated {{PREFIX}}.  This patch resolves that issue.

It also looks like I never submitted the first patch, so Jenkins never weighed in.  I'll make
sure to Jenkins runs this time.

> Many classes use bare yarn. properties instead of the defined constants
> -----------------------------------------------------------------------
>                 Key: YARN-5575
>                 URL: https://issues.apache.org/jira/browse/YARN-5575
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: YARN-5575.001.patch, YARN-5575.002.patch
> MAPREDUCE-5870 introduced the following line:
> {code}
>       conf.setInt("yarn.cluster.max-application-priority", 10);
> {code}
> It should instead be:
> {code}
>       conf.setInt(YarnConfiguration.MAX_CLUSTER_LEVEL_APPLICATION_PRIORITY, 10);
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message