hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith Sharma K S (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-4363) In TestFairScheduler, testcase should not create FairScheduler redundantly
Date Thu, 27 Oct 2016 05:27:58 GMT

     [ https://issues.apache.org/jira/browse/YARN-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rohith Sharma K S updated YARN-4363:
------------------------------------
    Attachment: YARN-4363.0002.patch

+1 for the patch.. patch is stale, I just rebased against trunk and reattaching the patch..
 I will commit patch once HadoopQA triggers. 

> In TestFairScheduler, testcase should not create FairScheduler redundantly
> --------------------------------------------------------------------------
>
>                 Key: YARN-4363
>                 URL: https://issues.apache.org/jira/browse/YARN-4363
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: fairscheduler
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Trivial
>         Attachments: YARN-4363.0002.patch, YARN-4363.001.patch
>
>
> I am trying to make some improvement on fairscheduler, but get some test failure on TestFairScheduler,
due to redundant FairScheduler creation:
> In TestFairScheduler, FairScheduler and RM is created, then set RMContext of RM to scheduler.
> {code}
> @Before
>   public void setUp() throws IOException {
>     scheduler = new FairScheduler();
>     conf = createConfiguration();
>     resourceManager = new MockRM(conf);
>     scheduler.setRMContext(resourceManager.getRMContext());
>   }
> {code}
> However in several case, scheduler is renewed, as a result RMcontext in scheduler is
null.
> {code}
>  @Test  
>   public void testMinZeroResourcesSettings() throws IOException {  
>     scheduler = new FairScheduler();
>     YarnConfiguration conf = new YarnConfiguration();
>     ...
>     scheduler.init(conf);
> {code}
> Then do scheduler.init(conf), I get a NPE(I try to get something from RMContext in scheduler
initialization).
> So FairScheduler should not be renewed in test block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message