hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane Kumpf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4269) Log aggregation should not swallow the exception during close()
Date Thu, 27 Oct 2016 23:27:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613643#comment-15613643

Shane Kumpf commented on YARN-4269:

Hey [~lichangleo] - It appears the patch no longer applies cleanly to trunk. 

I also see that {{IOUtils#cleanup}} almost meets your needs, but catches the wrong exception
and logs at the wrong priority. Given this, I would prefer an overloaded version of {{IOUtils#cleanup}}
vs {{IOUtils#closeStream}}. You could pass in the exception class and log priority and refactor
the existing {{IOUtils#cleanup}}. What do you think?

> Log aggregation should not swallow the exception during close()
> ---------------------------------------------------------------
>                 Key: YARN-4269
>                 URL: https://issues.apache.org/jira/browse/YARN-4269
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: log-aggregation
>            Reporter: Chang Li
>            Assignee: Chang Li
>              Labels: oct16-easy
>         Attachments: YARN-4269.2.patch, YARN-4269.3.patch, YARN-4269.patch
> the log aggregation thread ignores exception thrown by close(). It shouldn't be ignored,
since the file content may be missing or partial.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message