hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantinos Karanasos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3645) ResourceManager can't start success if attribute value of "aclSubmitApps" is null in fair-scheduler.xml
Date Mon, 31 Oct 2016 20:18:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623286#comment-15623286
] 

Konstantinos Karanasos commented on YARN-3645:
----------------------------------------------

Thanks for the new patch, [~gliptak].

I see there is one test failing. Can you please check if that is related?
Otherwise, the patch looks good to me.

bq. Elements "aclSubmitApps", "aclAdministerApps", "aclAdministerReservations", "aclListReservations",
"aclSubmitReservations" do not call trim() in the current code. Are these also expected to
call trim()?
[~kasha] If those properties should also call trim(), then we can push trim() inside the readFieldText()
method to simplify the code.

Other than that, and after double-checking that the test is not related, let's commit the
patch.

> ResourceManager can't start success if  attribute value of "aclSubmitApps" is null in
fair-scheduler.xml
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3645
>                 URL: https://issues.apache.org/jira/browse/YARN-3645
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.0.0-alpha2
>            Reporter: zhoulinlin
>            Assignee: Gabor Liptak
>              Labels: oct16-easy
>         Attachments: YARN-3645.1.patch, YARN-3645.2.patch, YARN-3645.3.patch, YARN-3645.4.patch,
YARN-3645.5.patch, YARN-3645.patch
>
>
> The "aclSubmitApps" is configured in fair-scheduler.xml like below:
> <queue name="mr">
>             <aclSubmitApps></aclSubmitApps>
>  </queue>
> The resourcemanager log:
> {noformat}
> 2015-05-14 12:59:48,623 INFO org.apache.hadoop.service.AbstractService: Service ResourceManager
failed in state INITED; cause: org.apache.hadoop.service.ServiceStateException: java.io.IOException:
Failed to initialize FairScheduler
> org.apache.hadoop.service.ServiceStateException: java.io.IOException: Failed to initialize
FairScheduler
> 	at org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:59)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:172)
> 	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:493)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:920)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:240)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:1159)
> Caused by: java.io.IOException: Failed to initialize FairScheduler
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.initScheduler(FairScheduler.java:1301)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.serviceInit(FairScheduler.java:1318)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	... 7 more
> Caused by: java.lang.NullPointerException
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.loadQueue(AllocationFileLoaderService.java:458)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.reloadAllocations(AllocationFileLoaderService.java:337)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.initScheduler(FairScheduler.java:1299)
> 	... 9 more
> 2015-05-14 12:59:48,623 INFO org.apache.hadoop.yarn.server.resourcemanager.ResourceManager:
Transitioning to standby state
> 2015-05-14 12:59:48,623 INFO com.zte.zdh.platformplugin.factory.YarnPlatformPluginProxyFactory:
plugin transitionToStandbyIn
> 2015-05-14 12:59:48,623 WARN org.apache.hadoop.service.AbstractService: When stopping
the service ResourceManager : java.lang.NullPointerException
> java.lang.NullPointerException
> 	at com.zte.zdh.platformplugin.factory.YarnPlatformPluginProxyFactory.transitionToStandbyIn(YarnPlatformPluginProxyFactory.java:71)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.transitionToStandby(ResourceManager.java:997)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceStop(ResourceManager.java:1058)
> 	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> 	at org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
> 	at org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:171)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:1159)
> 2015-05-14 12:59:48,623 FATAL org.apache.hadoop.yarn.server.resourcemanager.ResourceManager:
Error starting ResourceManager
> org.apache.hadoop.service.ServiceStateException: java.io.IOException: Failed to initialize
FairScheduler
> 	at org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:59)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:172)
> 	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:493)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:920)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:240)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:1159)
> Caused by: java.io.IOException: Failed to initialize FairScheduler
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.initScheduler(FairScheduler.java:1301)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.serviceInit(FairScheduler.java:1318)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
> 	... 7 more
> Caused by: java.lang.NullPointerException
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.loadQueue(AllocationFileLoaderService.java:458)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.reloadAllocations(AllocationFileLoaderService.java:337)
> 	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.initScheduler(FairScheduler.java:1299)
> 	... 9 more
> 2015-05-14 12:59:48,624 INFO com.zte.zdh.platformplugin.factory.YarnPlatformPluginProxyFactory:
plugin shutdown
> 2015-05-14 12:59:48,624 ERROR org.apache.hadoop.yarn.YarnUncaughtExceptionHandler: Thread
Thread[main,5,main] threw an Exception.
> java.lang.NullPointerException
> 	at com.zte.zdh.platformplugin.factory.YarnPlatformPluginProxyFactory.shutdown(YarnPlatformPluginProxyFactory.java:63)
> 	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:1167)
> 2015-05-14 12:59:48,627 INFO org.apache.hadoop.yarn.server.resourcemanager.ResourceManager:
SHUTDOWN_MSG: 
> {noformat}
> the reason:
> The method loadQueue in AllocationFileLoaderService.java :
> {code}
> else if ("aclSubmitApps".equals(field.getTagName())) {
>         String text = ((Text)field.getFirstChild()).getData();
>         acls.put(QueueACL.SUBMIT_APPLICATIONS, new  AccessControlList(text));
>       }
> {code}
> We  should check whether getFirstChild() is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message