Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 21 Sep 2016 18:19:20 +0000 (UTC)
From: "Sunil G (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13006496.1474464485000.629548.1474481960723@Atlassian.JIRA>
In-Reply-To: <JIRA.13006496.1474464485000@Atlassian.JIRA>
References: <JIRA.13006496.1474464485000@Atlassian.JIRA> <JIRA.13006496.1474464485255@arcas>
Subject: [jira] [Commented] (YARN-5660) Wrong audit constants are used in
 Get/Put of priority in RMWebService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 21 Sep 2016 18:19:23 -0000


    [ https://issues.apache.org/jira/browse/YARN-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510741#comment-15510741 ] 

Sunil G commented on YARN-5660:
-------------------------------

Hi [~naganarasimha_gr@apache.org]
We need audit log for failures too, correct? If application is not found for given app id, i think we can audit log the same for tracking purpose. Do you see some issues in this line.

> Wrong audit constants are used in Get/Put of priority in RMWebService
> ---------------------------------------------------------------------
>
>                 Key: YARN-5660
>                 URL: https://issues.apache.org/jira/browse/YARN-5660
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Trivial
>
> In methods {{RMWebService#getAppPriority}} and {{RMWebService#updateApplicationPriority}} uses wrong audit constants for RMAuditLogger. It should be AuditConstants.UPDATE_APP_PRIORITY
> {code}
> RMApp app = null;
>     try {
>       app = getRMAppForAppId(appId);
>     } catch (NotFoundException e) {
>       RMAuditLogger.logFailure(userName, AuditConstants.KILL_APP_REQUEST,
>           "UNKNOWN", "RMWebService",
>           "Trying to move an absent application " + appId);
>       throw e;
>     }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org