Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C05D0200B8F for ; Fri, 16 Sep 2016 03:09:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BED95160AC6; Fri, 16 Sep 2016 01:09:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4789160AD7 for ; Fri, 16 Sep 2016 03:09:21 +0200 (CEST) Received: (qmail 57112 invoked by uid 500); 16 Sep 2016 01:09:21 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 57098 invoked by uid 99); 16 Sep 2016 01:09:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Sep 2016 01:09:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D49F32C0D57 for ; Fri, 16 Sep 2016 01:09:20 +0000 (UTC) Date: Fri, 16 Sep 2016 01:09:20 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5642) Typos in 9 log messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 16 Sep 2016 01:09:22 -0000 [ https://issues.apache.org/jira/browse/YARN-5642?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15495= 027#comment-15495027 ]=20 Hadoop QA commented on YARN-5642: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {= color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {col= or} | {color:red} YARN-5642 does not apply to trunk. Rebase required? Wrong= Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {colo= r} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1282877= 8/YARN-5642.001.patch | | JIRA Issue | YARN-5642 | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13119= /console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Typos in 9 log messages=20 > ------------------------ > > Key: YARN-5642 > URL: https://issues.apache.org/jira/browse/YARN-5642 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Mehran Hassani > Priority: Trivial > Labels: newbie > Attachments: YARN-5642.001.patch > > > I am conducting research on log related bugs. I tried to make a tool to f= ix=1B repetitive yet simple patterns of bugs that are related to logs. Typo= s in log messages are one of the reoccurring bugs. Therefore, I made a tool= find typos in log statements. During my experiments, I managed to find the= following typos in Hadoop YARN: > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java= /org/apache/hadoop/yarn/event/AsyncDispatcher.java, LOG.info("AsyncDispatch= er is draining to stop igonring any new events."),=20 > igonring should be ignoring > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java= /org/apache/hadoop/yarn/security/YarnAuthorizationProvider.java, LOG.info(a= uthorizerClass.getName() + " is instiantiated."),=20 > instiantiated should be instantiated > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server= /applicationhistoryservice/FileSystemApplicationHistoryStore.java, LOG.info= ("Completed reading history information of all conatiners"+ " of applicatio= n attempt " + appAttemptId),=20 > conatiners should be containers > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/c= ontainermanager/monitor/ContainersMonitorImpl.java, LOG.info("Neither virut= al-memory nor physical-memory monitoring is " +"needed. Not running the mon= itor-thread"),=20 > virutal should be virtual > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcem= anager/reservation/AbstractReservationSystem.java, LOG.info("Intialized pla= n {} based on reservable queue {}" plan.toString() planQueueName),=20 > Intialized should be Initialized > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcem= anager/scheduler/capacity/LeafQueue.java, LOG.info("Initializing " + queueN= ame + "\n" +"capacity =3D " + queueCapacities.getCapacity() +" [=3D (float)= configuredCapacity / 100 ]" + "\n" +"asboluteCapacity =3D " + queueCapacit= ies.getAbsoluteCapacity() +" [=3D parentAbsoluteCapacity * capacity ]" + "\= n" +"maxCapacity =3D " + queueCapacities.getMaximumCapacity() +" [=3D confi= guredMaxCapacity ]" + "\n" +"absoluteMaxCapacity =3D " + queueCapacities.ge= tAbsoluteMaximumCapacity() +" [=3D 1.0 maximumCapacity undefined " +"(pare= ntAbsoluteMaxCapacity * maximumCapacity) / 100 otherwise ]" +"\n" +"userLim= it =3D " + userLimit +" [=3D configuredUserLimit ]" + "\n" +"userLimitFacto= r =3D " + userLimitFactor +" [=3D configuredUserLimitFactor ]" + "\n" +"max= Applications =3D " + maxApplications +" [=3D configuredMaximumSystemApplica= tionsPerQueue or" +" (int)(configuredMaximumSystemApplications * absoluteCa= pacity)]" +"\n" +"maxApplicationsPerUser =3D " + maxApplicationsPerUser +" = [=3D (int)(maxApplications * (userLimit / 100.0f) * " +"userLimitFactor) ]"= + "\n" +"usedCapacity =3D " + queueCapacities.getUsedCapacity() +" [=3D us= edResourcesMemory / " +"(clusterResourceMemory * absoluteCapacity)]" + "\n"= +"absoluteUsedCapacity =3D " + absoluteUsedCapacity +" [=3D usedResourcesM= emory / clusterResourceMemory]" + "\n" +"maxAMResourcePerQueuePercent =3D "= + maxAMResourcePerQueuePercent +" [=3D configuredMaximumAMResourcePercent = ]" + "\n" +"minimumAllocationFactor =3D " + minimumAllocationFactor +" [=3D= (float)(maximumAllocationMemory - minimumAllocationMemory) / " +"maximumAl= locationMemory ]" + "\n" +"maximumAllocation =3D " + maximumAllocation +" [= =3D configuredMaxAllocation ]" + "\n" +"numContainers =3D " + numContainers= +" [=3D currentNumContainers ]" + "\n" +"state =3D " + state +" [=3D confi= guredState ]" + "\n" +"acls =3D " + aclsString +" [=3D configuredAcls ]" + = "\n" +"nodeLocalityDelay =3D " + nodeLocalityDelay + "\n" +"labels=3D" + la= belStrBuilder.toString() + "\n" +"reservationsContinueLooking =3D " +reserv= ationsContinueLooking + "\n" +"preemptionDisabled =3D " + getPreemptionDisa= bled() + "\n" +"defaultAppPriorityPerQueue =3D " + defaultAppPriorityPerQue= ue),=20 > asbolute should be absolute > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcem= anager/scheduler/capacity/ParentQueue.java, LOG.info(queueName +" capacity= =3D" + this.queueCapacities.getCapacity() +" asboluteCapacity=3D" + this.q= ueueCapacities.getAbsoluteCapacity() +" maxCapacity=3D" + this.queueCapaci= ties.getMaximumCapacity() +" asboluteMaxCapacity=3D" + this.queueCapacitie= s.getAbsoluteMaximumCapacity() +" state=3D" + state +" acls=3D" + aclsStr= ing +" labels=3D" + labelStrBuilder.toString() + "\n" +" reservationsCont= inueLooking=3D" + reservationsContinueLooking),=20 > asbolute should be absolute > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcem= anager/scheduler/capacity/ParentQueue.java, LOG.info(queueName +" capacity= =3D" + this.queueCapacities.getCapacity() +" asboluteCapacity=3D" + this.q= ueueCapacities.getAbsoluteCapacity() +" maxCapacity=3D" + this.queueCapaci= ties.getMaximumCapacity() +" asboluteMaxCapacity=3D" + this.queueCapacitie= s.getAbsoluteMaximumCapacity() +" state=3D" + state +" acls=3D" + aclsStr= ing +" labels=3D" + labelStrBuilder.toString() + "\n" +" reservationsCont= inueLooking=3D" + reservationsContinueLooking), =09 asbolute should be abs= olute > In file /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-s= erver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcem= anager/scheduler/fair/FairScheduler.java, LOG.info("Calling allocate on rem= oved " +"or non existant application " + appAttemptId),=20 > existant should be existent =09 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org