Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 8 Sep 2016 01:32:20 +0000 (UTC)
From: "Allen Wittenauer (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13000530.1472250273000.514808.1473298340621@Atlassian.JIRA>
In-Reply-To: <JIRA.13000530.1472250273000@Atlassian.JIRA>
References: <JIRA.13000530.1472250273000@Atlassian.JIRA> <JIRA.13000530.1472250273865@arcas>
Subject: [jira] [Commented] (YARN-5567) Fix script exit code checking in
 NodeHealthScriptRunner#reportHealthStatus
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 08 Sep 2016 01:32:22 -0000


    [ https://issues.apache.org/jira/browse/YARN-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472384#comment-15472384 ] 

Allen Wittenauer commented on YARN-5567:
----------------------------------------

-1  Please revert this change.

The exit code getting ignored is *intentional*.  We don't want to bring the nodemanager down in case the script has a syntax error in it.  Such a condition would bring down *entire clusters* at once, instantaneously.


> Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
> --------------------------------------------------------------------------
>
>                 Key: YARN-5567
>                 URL: https://issues.apache.org/jira/browse/YARN-5567
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.8.0, 3.0.0-alpha1
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>             Fix For: 3.0.0-alpha1
>
>         Attachments: YARN-5567.001.patch
>
>
> In case of FAILED_WITH_EXIT_CODE, health status should be false.
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(true, "", now);
>         break;
> {code}
> should be 
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(false, "", now);
>         break;
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org