hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5660) Wrong audit constants are used in Get/Put of priority in RMWebService
Date Mon, 26 Sep 2016 13:31:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523064#comment-15523064
] 

Naganarasimha G R commented on YARN-5660:
-----------------------------------------

Well not sure why for all the REST queries are doing audit logs for failures when the app
id is not specified. So would be ok for doing this too, 
IMO is its a invalid input from user end and also not an update activity hence not sure why
audit log is required.

other than that latest patch looks fine except for the nit that 
{{RMAuditLogger.UPDATE_APP_PRIORITY}} can be used in {{RMWebServices.updateApplicationPriority}}
method instead of new constant {{APP_PRIORITY}}.


> Wrong audit constants are used in Get/Put of priority in RMWebService
> ---------------------------------------------------------------------
>
>                 Key: YARN-5660
>                 URL: https://issues.apache.org/jira/browse/YARN-5660
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Trivial
>         Attachments: YARN-5660.patch
>
>
> In methods {{RMWebService#getAppPriority}} and {{RMWebService#updateApplicationPriority}}
uses wrong audit constants for RMAuditLogger. It should be AuditConstants.UPDATE_APP_PRIORITY
> {code}
> RMApp app = null;
>     try {
>       app = getRMAppForAppId(appId);
>     } catch (NotFoundException e) {
>       RMAuditLogger.logFailure(userName, AuditConstants.KILL_APP_REQUEST,
>           "UNKNOWN", "RMWebService",
>           "Trying to move an absent application " + appId);
>       throw e;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message