hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5659) getPathFromYarnURL should use standard methods
Date Tue, 27 Sep 2016 18:36:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527046#comment-15527046

Wangda Tan commented on YARN-5659:

Oh got it, I looked at the patch in a wrong way.

{{public static URL fromURI(URI uri, Configuration conf)}}
{{public static URL fromPath(Path path, Configuration conf)}}
Are only added for unit test?

If so, to avoid adding unnecessary public API, could you make them to {{@private/@unstable/@visibleByTest}}?

> getPathFromYarnURL should use standard methods
> ----------------------------------------------
>                 Key: YARN-5659
>                 URL: https://issues.apache.org/jira/browse/YARN-5659
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: YARN-5659.01.patch, YARN-5659.02.patch, YARN-5659.03.patch, YARN-5659.04.patch,
YARN-5659.04.patch, YARN-5659.patch
> getPathFromYarnURL does some string shenanigans where  standard ctors should suffice.
> There are also bugs in it e.g. passing an empty scheme to the URI ctor is invalid, null
should be used. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message