hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gour Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5610) Initial code for native services REST API
Date Fri, 09 Sep 2016 02:15:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475640#comment-15475640
] 

Gour Saha commented on YARN-5610:
---------------------------------

On this point -
{quote}
Why do we need to explicitly call initHadoopBinding, which is already called the super.init()
previously.
{quote}
Actually, the init method needs to be overridden here, since initHadoopBinding does not get
invoked since we are binding the arguments with "help" as below -
{code}
      sliderClientConfiguration = client.bindArgs(sliderClientConfiguration,
          new String[] { "help" });
{code}
If you see ActionHelpArgs you will see that it overrides getHadoopServicesRequired and returns
false. Help is the safest action to bind since there are hardly any other action which does
not need any additional params (whose behavior can change in the future).

So, this code has to remain as is.


> Initial code for native services REST API
> -----------------------------------------
>
>                 Key: YARN-5610
>                 URL: https://issues.apache.org/jira/browse/YARN-5610
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gour Saha
>            Assignee: Gour Saha
>         Attachments: YARN-4793-yarn-native-services.001.patch
>
>
> This task will be used to submit and review patches for the initial code drop for the
native services REST API 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message