hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5605) Preempt containers (all on one node) to meet the requirement of starved applications
Date Mon, 12 Sep 2016 17:18:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484679#comment-15484679
] 

ASF GitHub Bot commented on YARN-5605:
--------------------------------------

Github user templedf commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/124#discussion_r78414451
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
---
    @@ -535,6 +535,23 @@ public synchronized Resource getResource(SchedulerRequestKey schedulerKey)
{
       }
     
       /**
    +   * Method to return the next resource request to be serviced.
    +   *
    +   * In the initial implementation, we just pick any {@link ResourceRequest}
    +   * corresponding to the highest priority.
    +   *
    +   * @return next {@link ResourceRequest} to allocate resources for.
    +   */
    +  @Unstable
    +  public synchronized ResourceRequest getNextResourceRequest() {
    +    for (ResourceRequest rr:
    +        resourceRequestMap.get(schedulerKeys.first()).values()) {
    +      return rr;
    --- End diff --
    
    It's stylistic, and there's no guideline about multiple exit points that I know of, so
I won't push it.  I don't think this form is very future-safe, though.


> Preempt containers (all on one node) to meet the requirement of starved applications
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-5605
>                 URL: https://issues.apache.org/jira/browse/YARN-5605
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-5605-1.patch, yarn-5605-2.patch
>
>
> Required items:
> # Identify starved applications
> # Identify a node that has enough containers from applications over their fairshare.
> # Preempt those containers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message