hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5605) Preempt containers (all on one node) to meet the requirement of starved applications
Date Mon, 12 Sep 2016 17:13:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484660#comment-15484660
] 

ASF GitHub Bot commented on YARN-5605:
--------------------------------------

Github user templedf commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/124#discussion_r78413426
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSPreemptionThread.java
---
    @@ -0,0 +1,173 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
    +import org.apache.hadoop.yarn.api.records.ContainerStatus;
    +import org.apache.hadoop.yarn.api.records.Resource;
    +import org.apache.hadoop.yarn.api.records.ResourceRequest;
    +import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainer;
    +import org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerEventType;
    +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils;
    +import org.apache.hadoop.yarn.util.resource.Resources;
    +
    +import java.util.ArrayList;
    +import java.util.Comparator;
    +import java.util.List;
    +import java.util.Timer;
    +import java.util.TimerTask;
    +
    +/**
    + * Thread that handles FairScheduler preemption
    + */
    +public class FSPreemptionThread extends Thread {
    +  private static final Log LOG = LogFactory.getLog(FSPreemptionThread.class);
    +  private final FSContext context;
    +  private final FairScheduler scheduler;
    +  private final long warnTimeBeforeKill;
    +  private final Timer preemptionTimer;
    +
    +  public FSPreemptionThread(FairScheduler scheduler) {
    +    this.scheduler = scheduler;
    +    this.context = scheduler.getContext();
    +    FairSchedulerConfiguration fsConf = scheduler.getConf();
    +    context.setPreemptionEnabled();
    +    context.setPreemptionUtilizationThreshold(
    +        fsConf.getPreemptionUtilizationThreshold());
    +    warnTimeBeforeKill = fsConf.getWaitTimeBeforeKill();
    +    preemptionTimer = new Timer("Preemption Timer", true);
    +
    +    setDaemon(true);
    +    setName("FSPreemptionThread");
    +  }
    +
    +  public void run() {
    +    while (!Thread.interrupted()) {
    +      FSAppAttempt starvedApp;
    +      try{
    +        starvedApp = context.getStarvedApps().take();
    +        if (Resources.none().equals(starvedApp.getStarvation())) {
    +          continue;
    +        }
    +      } catch (InterruptedException e) {
    +        LOG.info("Preemption thread interrupted! Exiting.");
    +        return;
    --- End diff --
    
    I think I was a little confused.  How about this:
    
    ~~~~
          try{
            starvedApp = context.getStarvedApps().take();
            if (!Resources.none().equals(starvedApp.getStarvation())) {
              List<RMContainer> containers = identifyContainersToPreempt(starvedApp);
              if (containers != null) {
                preemptContainers(containers);
              }
            }
          } catch (InterruptedException e) {
            LOG.info("Preemption thread interrupted! Exiting.");
            interrupt();
          }
    ~~~~
    
    It does some extra work inside the _try_, but the logic is much simpler.


> Preempt containers (all on one node) to meet the requirement of starved applications
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-5605
>                 URL: https://issues.apache.org/jira/browse/YARN-5605
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-5605-1.patch, yarn-5605-2.patch
>
>
> Required items:
> # Identify starved applications
> # Identify a node that has enough containers from applications over their fairshare.
> # Preempt those containers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message