hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ray Chiang (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (YARN-5567) Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
Date Thu, 01 Sep 2016 22:23:20 GMT

     [ https://issues.apache.org/jira/browse/YARN-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ray Chiang resolved YARN-5567.
------------------------------
      Resolution: Fixed
    Hadoop Flags: Incompatible change,Reviewed  (was: Reviewed)
    Release Note: Prior to this fix, the NodeManager will ignore any non-zero exit code for
any script in the yarn.nodemanager.health-checker.script.path property.  With this change,
any syntax errors in the health checking script will get flagged as an error in the same fashion
(likely exit code 1) that the script detecting a health issue.  (was: Prior to this fix, the
NodeManager will ignore any non-zero exit code for any script in the yarn.nodemanager.health-checker.script.path
property.)

Thanks [~andrew.wang] for the info.  Thanks to [~wilfreds] for bringing up the issue and thanks
again to [~yufeigu] and [~Naganarasimha] for your comments.

Reverted from branch-2.8 and branch-2.  Marked as incompatible.

> Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
> --------------------------------------------------------------------------
>
>                 Key: YARN-5567
>                 URL: https://issues.apache.org/jira/browse/YARN-5567
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.8.0, 3.0.0-alpha1
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>             Fix For: 3.0.0-alpha1
>
>         Attachments: YARN-5567.001.patch
>
>
> In case of FAILED_WITH_EXIT_CODE, health status should be false.
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(true, "", now);
>         break;
> {code}
> should be 
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(false, "", now);
>         break;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message