hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith Sharma K S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5375) invoke MockRM#drainEvents implicitly in MockRM methods to reduce test failures
Date Tue, 27 Sep 2016 05:30:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525120#comment-15525120
] 

Rohith Sharma K S commented on YARN-5375:
-----------------------------------------

I am +1 for sync-statestore patch. I just went through the patch and some comments from the
patch.
# {{private volatile boolean drained = true;}} default value has been changed. Would you tell
why this change required?
# I think change in the method static to non-static not necessarily required in MockRM#waitForState.
Lets keep it as it is. As a result, MockAM modifications are not at all required.
# nit: couple of changes which are not modified are appeared in patch. May be check those
also, else patch looks very huge. Ex : MockRM class, line no 349, 332
# One doubt, if once * disableDrainEventsImplicitly* set  then there is no way to enable it.
 Should we provide enabling method also?
# After this patch, can sleeps can be avoided ? If yes, I think we need to remove so that
test execute faster. 

> invoke MockRM#drainEvents implicitly in MockRM methods to reduce test failures
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5375
>                 URL: https://issues.apache.org/jira/browse/YARN-5375
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: sandflee
>            Assignee: sandflee
>         Attachments: YARN-5375.01.patch, YARN-5375.03.patch, YARN-5375.04.patch, YARN-5375.05.patch,
YARN-5375.06.patch, YARN-5375.07-drain-statestore.patch, YARN-5375.07-sync-statestore.patch
>
>
> seen many test failures related to RMApp/RMAppattempt comes to some state but some event
are not processed in rm event queue or scheduler event queue, cause test failure, seems we
could implicitly invokes drainEvents(should also drain sheduler event) in some mockRM method
like waitForState



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message