hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Vasudev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5366) Add support for toggling the removal of completed and failed docker containers
Date Thu, 08 Sep 2016 11:44:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473641#comment-15473641
] 

Varun Vasudev commented on YARN-5366:
-------------------------------------

Thanks for the updated patch [~shanekumpf@gmail.com]. Couple of changes required for the latest
patch -
1)
Can you add a test case to verify that when YarnConfiguration.NM_DOCKER_ALLOW_KEEP_CONTAINER_ON_EXIT
is set to false - the docker rm command is called

2)
Can you fix this checkstyle warning - 
bq. ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerContainerStatusHandler.java:0::
Missing package-info.java file.

You'll need to add the package-info.java file.

Rest of the patch looks good to me.

> Add support for toggling the removal of completed and failed docker containers
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5366
>                 URL: https://issues.apache.org/jira/browse/YARN-5366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Shane Kumpf
>            Assignee: Shane Kumpf
>         Attachments: YARN-5366.001.patch, YARN-5366.002.patch, YARN-5366.003.patch, YARN-5366.004.patch
>
>
> Currently, completed and failed docker containers are removed by container-executor.
Add a job level environment variable to DockerLinuxContainerRuntime to allow the user to toggle
whether they want the container deleted or not and remove the logic from container-executor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message