hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane Kumpf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5366) Add support for toggling the removal of completed and failed docker containers
Date Wed, 07 Sep 2016 14:22:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470769#comment-15470769
] 

Shane Kumpf commented on YARN-5366:
-----------------------------------

Thank you for the review, [~vvasudev]! The latest patch addresses the unit test failure and
your comments. The checkstyle errors are due to package line length and method line count.

I have addressed #1, although to support container reacquisition on NM restart, the check
still has to occur in signalContainer as well. The environment variable value is also checked
in launchContainer to allow the container to fail fast due to invalid values.

Regarding #6, moving to a switch/case would require compile time constants that would duplicate
what is already available in the enum, as a result I've left these as if/else.

For #9, I'm not creating that file, it is a preexisting script that dumps the params passed
to it. This allows for checking the params when calling container executor. This pattern is
used elsewhere in existing unit tests.

#2, #3, #4, #5, #7, #8, and #10 have been addressed.

I believe the changes are ready for review. Thanks!

> Add support for toggling the removal of completed and failed docker containers
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5366
>                 URL: https://issues.apache.org/jira/browse/YARN-5366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Shane Kumpf
>            Assignee: Shane Kumpf
>         Attachments: YARN-5366.001.patch, YARN-5366.002.patch, YARN-5366.003.patch, YARN-5366.004.patch
>
>
> Currently, completed and failed docker containers are removed by container-executor.
Add a job level environment variable to DockerLinuxContainerRuntime to allow the user to toggle
whether they want the container deleted or not and remove the logic from container-executor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message