hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4855) Should check if node exists when replace nodelabels
Date Mon, 19 Sep 2016 18:06:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504186#comment-15504186

Wangda Tan commented on YARN-4855:

Thanks [~Tao Jie] a lot for updating the patch!
Generally approach looks good, some comments:

1) Rename suggestions:
- {{ReplaceLabelsOnNodeRequest#setVerifyNodes/getVerifyNodes}} to {{get/setFailOnUnknownNodes}}
- Same for yarn_server_resourcemanager_service_protos.proto changes

2) AdminService:
- For node with port specified (and port != 0), could you use the map to look up key exists
(use containsKey) instead of look and compare? 
- Inaddition to getRMNodes, I think we also need to check getInactiveRMNodes, node which is
decommissioning should be treated as known node, to me it is a valid use case to modify label
 f decommissioning nodes.

> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch, YARN-4855.002.patch, YARN-4855.003.patch, YARN-4855.004.patch,
YARN-4855.005.patch, YARN-4855.006.patch, YARN-4855.007.patch, YARN-4855.008.patch, YARN-4855.009.patch,
> Today when we add nodelabels to nodes, it would succeed even if nodes are not existing
NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode --fail-on-unkown-nodes "node1=label1"*
, it would be denied if node is unknown.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message