hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4855) Should check if node exists when replace nodelabels
Date Fri, 02 Sep 2016 19:13:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459352#comment-15459352
] 

Naganarasimha G R commented on YARN-4855:
-----------------------------------------

Hi [~Tao Jie],
Sorry for the really long delay in reviewing, Some nits what i found in the patch are :
# findbugs issue is there need to be corrected
# checkstyle issue still exists, see the white space 
# acceptNode => isRMRegisteredNode or isValidNode, former seems to be better
# "./yarn rmadmin -replaceLabelsOnNode " then error message is not displayed and silently
finishes
# seems like RMAdminCLI doesnt require both {{setYarnClient}} and {{createYarnClient}}.



> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch, YARN-4855.002.patch, YARN-4855.003.patch, YARN-4855.004.patch,
YARN-4855.005.patch, YARN-4855.006.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not existing
NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode --fail-on-unkown-nodes "node1=label1"*
, it would be denied if node is unknown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message