hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3142) Improve locks in AppSchedulingInfo
Date Thu, 22 Sep 2016 20:37:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514415#comment-15514415
] 

Wangda Tan commented on YARN-3142:
----------------------------------

[~varun_saxena], 

bq. But we wont be using this till we set current attempt in scheduler which is after this.
Also, this is a reference assignment which is atomic. Thoughts ?

Yeah it should not required.

bq. You mean remove the request from the resource request map ? Well the part about fetching
from resource request map i.e. call to getResourceRequest is within locks. After that we just
access ResourceRequest instance. And capability which we are returning here wont be changed
even by another thread. However this is is not immutable field so we can probably guard it
with a read lock just to be safe. Thoughts ?

Agree we can add a readlock here just to be safe.

> Improve locks in AppSchedulingInfo
> ----------------------------------
>
>                 Key: YARN-3142
>                 URL: https://issues.apache.org/jira/browse/YARN-3142
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>            Assignee: Varun Saxena
>         Attachments: YARN-3142.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message