hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3140) Improve locks in AbstractCSQueue/LeafQueue/ParentQueue
Date Thu, 15 Sep 2016 18:35:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494172#comment-15494172
] 

Wangda Tan commented on YARN-3140:
----------------------------------

Thanks [~jianhe] for review,

Addressed all comments, except:

bq. private synchronized CSAssignment assignContainersToChildQueues 
It is already protected by writelocks inside assignContainers, so there's no need to keep
the writelock inside assignContainersToChildQueues 

Any other comments?

(Uploaded ver.3 patch) 

> Improve locks in AbstractCSQueue/LeafQueue/ParentQueue
> ------------------------------------------------------
>
>                 Key: YARN-3140
>                 URL: https://issues.apache.org/jira/browse/YARN-3140
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3140.1.patch, YARN-3140.2.patch, YARN-3140.3.patch
>
>
> Enhance locks in AbstractCSQueue/LeafQueue/ParentQueue, as mentioned in YARN-3091, a
possible solution is using read/write lock. Other fine-graind locks for specific purposes
/ bugs should be addressed in separated tickets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message