Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 29 Aug 2016 20:29:20 +0000 (UTC)
From: "Min Shen (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12998616.1471647754000.439867.1472502560586@Atlassian.JIRA>
In-Reply-To: <JIRA.12998616.1471647754000@Atlassian.JIRA>
References: <JIRA.12998616.1471647754000@Atlassian.JIRA> <JIRA.12998616.1471647754487@arcas>
Subject: [jira] [Commented] (YARN-5543) ResourceManager SchedulingMonitor
 could potentially terminate the preemption checker thread
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 29 Aug 2016 20:29:22 -0000


    [ https://issues.apache.org/jira/browse/YARN-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446963#comment-15446963 ] 

Min Shen commented on YARN-5543:
--------------------------------

[~wangda],

Revised patch attached. Could you please take a look?

> ResourceManager SchedulingMonitor could potentially terminate the preemption checker thread
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-5543
>                 URL: https://issues.apache.org/jira/browse/YARN-5543
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler, resourcemanager
>    Affects Versions: 2.7.0, 2.6.1
>            Reporter: Min Shen
>            Assignee: Min Shen
>         Attachments: YARN-5543.001.patch, YARN-5543.002.patch
>
>
> In SchedulingMonitor.java, when the service starts, it starts a checker thread to perform Capacity Scheduler's preemption. However, the implementation of this checker thread has the following issue:
> {code}
> while (!stopped && !Thread.currentThread().isInterrupted()) {
>     ....
>     try {
>       Thread.sleep(monitorInterval)
>     } catch (InterruptedException e) {
>       ....
>       break;
>     }
> }
> {code}
> The above code snippet will terminate the checker thread whenever it is interrupted. 
> We noticed in our cluster that this could lead to CapacityScheduler's preemption disabled unexpectedly due to the checker thread getting terminated.
> We propose to use ScheduledExecutorService to improve the robustness of this part of the code to ensure the liveness of CapacityScheduler's preemption functionality.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org