Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 150A6200B70 for ; Sat, 13 Aug 2016 02:52:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 13B1E160AB9; Sat, 13 Aug 2016 00:52:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5AA16160AB0 for ; Sat, 13 Aug 2016 02:52:24 +0200 (CEST) Received: (qmail 54950 invoked by uid 500); 13 Aug 2016 00:52:23 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 54930 invoked by uid 99); 13 Aug 2016 00:52:23 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Aug 2016 00:52:23 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 951442C02A5 for ; Sat, 13 Aug 2016 00:52:22 +0000 (UTC) Date: Sat, 13 Aug 2016 00:52:22 +0000 (UTC) From: "Subru Krishnan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5519) Add SubClusterId in AddApplicationHomeSubClusterResponse for Router Failover MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 13 Aug 2016 00:52:25 -0000 [ https://issues.apache.org/jira/browse/YARN-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419741#comment-15419741 ] Subru Krishnan commented on YARN-5519: -------------------------------------- Thanks [~ellenfkh] for the patch. It mostly looks good, couple of minor comments: * Add Javadocs for the getter/setter for new _subClusterId_ field in {{AddApplicationHomeSubClusterResponse}}. Mention clearly that the _subClusterId_ in response might be different from input in casing the mapping already exists. * The changes in {{MemoryFederationStateStore::updateApplicationHomeSubCluster}} are redundant. > Add SubClusterId in AddApplicationHomeSubClusterResponse for Router Failover > ---------------------------------------------------------------------------- > > Key: YARN-5519 > URL: https://issues.apache.org/jira/browse/YARN-5519 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Giovanni Matteo Fumarola > Assignee: Ellen Hui > Attachments: YARN-5519-YARN-2915.v1.patch > > > This JIRA tracks the addition of SubClusterId into AddApplicationHomeSubClusterResponse. > in the design of [YARN-3659|https://issues.apache.org/jira/browse/YARN-3659], to handle better fail-over scenario the response needs SubclusterId as field. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org