Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EC2D6200B71 for ; Wed, 17 Aug 2016 03:41:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EABF3160ABC; Wed, 17 Aug 2016 01:41:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 65632160AA8 for ; Wed, 17 Aug 2016 03:41:21 +0200 (CEST) Received: (qmail 7278 invoked by uid 500); 17 Aug 2016 01:41:20 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 7266 invoked by uid 99); 17 Aug 2016 01:41:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 01:41:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 717952C02A4 for ; Wed, 17 Aug 2016 01:41:20 +0000 (UTC) Date: Wed, 17 Aug 2016 01:41:20 +0000 (UTC) From: "Subru Krishnan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5467) InputValidator for the FederationStateStore internal APIs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 17 Aug 2016 01:41:22 -0000 [ https://issues.apache.org/jira/browse/YARN-5467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423736#comment-15423736 ] Subru Krishnan commented on YARN-5467: -------------------------------------- [~giovanni.fumarola], the latest patch LGTM. I just have one request, can you use slf4j instead of log4j for the Logger especially since these are new classes. Thanks. > InputValidator for the FederationStateStore internal APIs > --------------------------------------------------------- > > Key: YARN-5467 > URL: https://issues.apache.org/jira/browse/YARN-5467 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Subru Krishnan > Assignee: Giovanni Matteo Fumarola > Attachments: YARN-5467-YARN-2915.v0.patch, YARN-5467-YARN-2915.v1.patch, YARN-5467-YARN-2915.v2.patch, YARN-5467-YARN-2915.v3.patch, YARN-5467-YARN-2915.v4.patch, YARN-5467-YARN-2915.v5.patch, YARN-5467-YARN-2915.v6.patch > > > We need to check for mandatory fields, well formed-ness (for address fields) etc of input params to FederationStateStore. This is common across all Store implementations and can be used as a _fail-fast_ mechanism on the client side. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org