Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 162D8200B51 for ; Mon, 1 Aug 2016 18:39:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 14D04160AAF; Mon, 1 Aug 2016 16:39:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 83699160A66 for ; Mon, 1 Aug 2016 18:39:21 +0200 (CEST) Received: (qmail 43100 invoked by uid 500); 1 Aug 2016 16:39:20 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 43071 invoked by uid 99); 1 Aug 2016 16:39:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2016 16:39:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8B5992C0D5F for ; Mon, 1 Aug 2016 16:39:20 +0000 (UTC) Date: Mon, 1 Aug 2016 16:39:20 +0000 (UTC) From: "Xuan Gong (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5226) remove AHS enable check from LogsCLI#fetchAMContainerLogs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 01 Aug 2016 16:39:22 -0000 [ https://issues.apache.org/jira/browse/YARN-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402374#comment-15402374 ] Xuan Gong commented on YARN-5226: --------------------------------- Thanks for the review. [~djp] bq. I think we may add an additional check on timeline service enabled? That is a good point. But we do not need to do this check in LogsCLI. We are using YarnClient which would handle all the cases, including the check on whether the timeline service is enabled. > remove AHS enable check from LogsCLI#fetchAMContainerLogs > --------------------------------------------------------- > > Key: YARN-5226 > URL: https://issues.apache.org/jira/browse/YARN-5226 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Xuan Gong > Assignee: Xuan Gong > Attachments: YARN-5226.1.patch, YARN-5226.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org