Return-Path: <yarn-issues-return-94500-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7E5B1200B7D
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 26 Aug 2016 18:50:23 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7D01D160AC3; Fri, 26 Aug 2016 16:50:23 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id CA78B160AB6
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 26 Aug 2016 18:50:22 +0200 (CEST)
Received: (qmail 93174 invoked by uid 500); 26 Aug 2016 16:50:22 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 93142 invoked by uid 99); 26 Aug 2016 16:50:21 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Aug 2016 16:50:21 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id B375B2C0166
	for <yarn-issues@hadoop.apache.org>; Fri, 26 Aug 2016 16:50:21 +0000 (UTC)
Date: Fri, 26 Aug 2016 16:50:21 +0000 (UTC)
From: "Junping Du (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12647412.1368489598000.422031.1472230221732@Atlassian.JIRA>
In-Reply-To: <JIRA.12647412.1368489598000@Atlassian.JIRA>
References: <JIRA.12647412.1368489598000@Atlassian.JIRA> <JIRA.12647412.1368489598145@arcas>
Subject: [jira] [Commented] (YARN-679) add an entry point that can start any
 Yarn service
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 26 Aug 2016 16:50:23 -0000


    [ https://issues.apache.org/jira/browse/YARN-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439375#comment-15439375 ] 

Junping Du commented on YARN-679:
---------------------------------

Agree with [~templedf] that this is well written javadoc that can be good example for reference in future. :)
Good to see we finally figure out Jenkins' problem last week. Sorry I haven't figure out too much time this week to review it thoroughly. Just have some level comments here:
1. It looks like all changes are in hadoop-common project currently. If so, shall we turn it into Hadoop JIRA instead of a YARN issue? Or we think these APIs only get used for YARN application. If so, may be we should consider to refactor most code to under hadoop-yarn-project (like: yarn-api)?

2. The lifecycle of yarn service looks good to me. However, I haven't see an detail example to show case how an application can use these code to launch yarn service. Do we have a quick dummy application here or we can plan to add one in future.


3. I saw we were wrapping a lot of error code here around all kinds of exceptions or HTTP code.
{noformat}
+ * <pre>
+ *    0-10: general command issues
+ *   30-39: equivalent to the 3XX responses, where those responses are
+ *          considered errors by the application.
+ *   40-49: client-side/CLI/config problems
+ *   50-59: service-side problems.
+ *   60+  : application specific error codes
+ * </pre>
{noformat}
It sounds like 11-20 is vacant. Is that reserved for other purpose. Also, if error code is used out (like service side problem is more than 10 kinds). How can we extend according to current design?

I need more time for check more details of the patch which is very huge now. 

> add an entry point that can start any Yarn service
> --------------------------------------------------
>
>                 Key: YARN-679
>                 URL: https://issues.apache.org/jira/browse/YARN-679
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: api
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-679-001.patch, YARN-679-002.patch, YARN-679-002.patch, YARN-679-003.patch, YARN-679-004.patch, YARN-679-005.patch, YARN-679-006.patch, YARN-679-007.patch, YARN-679-008.patch, YARN-679-009.patch, YARN-679-010.patch, YARN-679-011.patch, org.apache.hadoop.servic...mon 3.0.0-SNAPSHOT API).pdf
>
>          Time Spent: 72h
>  Remaining Estimate: 0h
>
> There's no need to write separate .main classes for every Yarn service, given that the startup mechanism should be identical: create, init, start, wait for stopped -with an interrupt handler to trigger a clean shutdown on a control-c interrupt.
> Provide one that takes any classname, and a list of config files/options



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org