hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5567) Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
Date Tue, 30 Aug 2016 04:34:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448000#comment-15448000
] 

Naganarasimha G R commented on YARN-5567:
-----------------------------------------

Thanks for pointing it out [~wilfreds], but it was not completely overlooked by me. My thoughts
behind going ahead with this issue is, if the script has syntax error then there is possibility
that the script might not execute properly and detect any issues with the node's health (if
any). So i felt warning to the user that the script has error(or returning a error code) is
better than just passing the evaluation as successful. 
bq. If we are going to change the behaviour that is documented we should not do it in release
2.8.1 and also update all related documentation.
Agree that required documentation and comments needs to be modified/upgrade (which we missed
in the patch). But not to do in 2.8.1 release is a debatable topic which can be further discussed
upon. Few points in favor of doing it is, 
# we are doing the change in minor version than the major version. (2.8.0 is not yet released
and if possible we can incorporate in it too)
# As mentioned above if there is issue in the script better to flag it as an error rather
than silently passing it as success, so better to flag an error if any script issues even
for existing cluster too.

Thoughts ? would also like to see others input too


> Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
> --------------------------------------------------------------------------
>
>                 Key: YARN-5567
>                 URL: https://issues.apache.org/jira/browse/YARN-5567
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.8.0, 3.0.0-alpha1
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>             Fix For: 2.8.1
>
>         Attachments: YARN-5567.001.patch
>
>
> In case of FAILED_WITH_EXIT_CODE, health status should be false.
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(true, "", now);
>         break;
> {code}
> should be 
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(false, "", now);
>         break;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message