hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5557) Add localize API to the ContainerManagementProtocol
Date Thu, 25 Aug 2016 00:11:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435986#comment-15435986
] 

Junping Du commented on YARN-5557:
----------------------------------

Thanks [~jianhe] for delivering a patch! The patch looks good in overall. However, as I mentioned
in parent issue, we may need to handle AM/NM restart cases. If so, ResourceLocalizationResponse
may need to include field to mark if persistent request in NM side is successful or not. Isn't
it? 
In addition, I found we don't actually include unit test for PBImpl changes. Please add new
added protocols to TestPBImplRecords for proper testing. Also, we should fix javadoc warning
here.

> Add localize API to the ContainerManagementProtocol
> ---------------------------------------------------
>
>                 Key: YARN-5557
>                 URL: https://issues.apache.org/jira/browse/YARN-5557
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-5557.1.patch
>
>
> A new localize API for localizing new resources. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message