hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5505) Create an agent-less docker provider
Date Tue, 23 Aug 2016 11:07:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432620#comment-15432620
] 

Jian He commented on YARN-5505:
-------------------------------

Thanks Billie, some comments on the patch

- DockerProviderService# logFolderExports, workFolderExports not used, remove ?

- Could you help adding brief comments to what each method in ProviderUtils is doing ? It
was quite difficult for me to figure out. especially the ones like  ProviderUtils#buildConfigurations,
addNamedConfiguration, dereferenceAllConfigs, propagateOptions, ConfigUtils#prepConfigForTemplateOutputter
 
- IIUC, this is for agent to talk to AM, given that we don’t have agent, this is not needed?
{code}
if (providerUtils.hasTwoWaySSLEnabled(appConf.getComponent(COMPONENT_AM))) {
  providerUtils.localizeContainerSSLResources(launcher,
container,
      fileSystem, getClusterName());
}
{code}
- remove DockerProviderFactory#CLASSSNAME, not used
- In ProviderUtils, the configList could be created as a HashSet in the first place?
{code}
return new ArrayList<>(new HashSet<>(configList));
{code}
- DockerProviderService#containerInfo: once added into this map, the object is never removed.
this will cause leak if container fails and retry etc. I think we don’t need to maintain
this separate map, we can rely on the RoleInstance in appState from the caller of this method?

> Create an agent-less docker provider
> ------------------------------------
>
>                 Key: YARN-5505
>                 URL: https://issues.apache.org/jira/browse/YARN-5505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-5505-yarn-native-services.001.patch
>
>
> The Slider AM has a pluggable portion called a provider. Currently the only provider
implementation is the agent provider which contains the bulk of the agent-related Java code.
We can implement a docker provider that does not use the agent and gets information it needs
directly from the NM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message