hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5389) TestYarnClient#testReservationDelete fails in trunk
Date Mon, 22 Aug 2016 15:12:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430955#comment-15430955
] 

Jason Lowe commented on YARN-5389:
----------------------------------

Thanks for the patch!

We should not add longer sleeps in tests.  It just makes the tests run much slower overall.
 If the problem is that the polling loop doesn't run long enough then instead of increasing
the sleep time per loop it would be better to increase the number of loop iterations.  Otherwise
we could waste up to a full second.  I know that doesn't sound like much, but when that loss
is aggregated over thousands of tests doing things like this it quickly adds up to tens of
minutes.  See the discussion in YARN-5393.

My preference would be to lower the sleep time to 10 msec and increase the iterations accordingly
to achieve the targeted total duration we will wait.  GenericTestUtils#waitFor can be leveraged
if desired.

> TestYarnClient#testReservationDelete fails in trunk
> ---------------------------------------------------
>
>                 Key: YARN-5389
>                 URL: https://issues.apache.org/jira/browse/YARN-5389
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: Rohith Sharma K S
>            Assignee: Sean Po
>              Labels: test
>         Attachments: YARN-5389.v1.patch
>
>
> In build report [report|https://builds.apache.org/job/PreCommit-YARN-Build/12341/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt],
below test fails. 
> {noformat}
> Tests run: 28, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 26.066 sec <<<
FAILURE! - in org.apache.hadoop.yarn.client.api.impl.TestYarnClient
> testReservationDelete(org.apache.hadoop.yarn.client.api.impl.TestYarnClient)  Time elapsed:
2.213 sec  <<< FAILURE!
> java.lang.AssertionError: Exhausted attempts in checking if node capacity was added to
the plan
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.apache.hadoop.yarn.client.api.impl.TestYarnClient.setupMiniYARNCluster(TestYarnClient.java:1222)
> 	at org.apache.hadoop.yarn.client.api.impl.TestYarnClient.testReservationDelete(TestYarnClient.java:1584)
> testListReservationsByInvalidTimeInterval(org.apache.hadoop.yarn.client.api.impl.TestYarnClient)
 Time elapsed: 2.215 sec  <<< FAILURE!
> java.lang.AssertionError: Exhausted attempts in checking if node capacity was added to
the plan
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.apache.hadoop.yarn.client.api.impl.TestYarnClient.setupMiniYARNCluster(TestYarnClient.java:1222)
> 	at org.apache.hadoop.yarn.client.api.impl.TestYarnClient.testListReservationsByInvalidTimeInterval(TestYarnClient.java:1444)
> testListReservationsByTimeIntervalContainingNoReservations(org.apache.hadoop.yarn.client.api.impl.TestYarnClient)
 Time elapsed: 2.206 sec  <<< FAILURE!
> java.lang.AssertionError: Exhausted attempts in checking if node capacity was added to
the plan
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.apache.hadoop.yarn.client.api.impl.TestYarnClient.setupMiniYARNCluster(TestYarnClient.java:1222)
> 	at org.apache.hadoop.yarn.client.api.impl.TestYarnClient.testListReservationsByTimeIntervalContainingNoReservations(TestYarnClient.java:1494)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message