hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5264) Use FSQueue to store queue-specific information
Date Tue, 30 Aug 2016 13:37:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449031#comment-15449031
] 

Daniel Templeton commented on YARN-5264:
----------------------------------------

Thanks for cleaning this mess up, [~yufeigu].  Nice job on putting together a clean patch.
 My only comment is a macro-level one.  You did all of this work to move the weights and shares
and such from the maps in {{AllocationConfiguration}} into the queue tree.  You added the
information to the queues, but you didn't remove it from the {{AllocationConfiguration}}.
 You're now storing the data twice, though the {{AllocationConfiguration}}'s copy of the data
is only used to initialize the queues.  Think you can get rid of the corresponding maps in
{{AllocationConfiguration}}?

> Use FSQueue to store queue-specific information
> -----------------------------------------------
>
>                 Key: YARN-5264
>                 URL: https://issues.apache.org/jira/browse/YARN-5264
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-5264.001.patch, YARN-5264.002.patch, YARN-5264.003.patch
>
>
> Use FSQueue to store queue-specific information instead of querying AllocationConfiguration.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message