hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4889) Changes in AMRMClient for identifying resource-requests explicitly
Date Wed, 17 Aug 2016 18:57:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425174#comment-15425174
] 

Karthik Kambatla commented on YARN-4889:
----------------------------------------

The patch looks pretty reasonable, but for these nits. +0, once these are addressed. I am
not very familiar with AMRMClient code, and would be nice for someone who worked on this before
to take a look. 

Comments/nits:
# AMRMClient#getMatchingRequests does not have @param in the javadoc. Can we reword the NOTE
to add the @param. 
# A bunch of comments seem to take the form "WITH(OUT) the allocationRequestId specified".
Can we reword them to "with/without the/a specified allocationRequestId"?
# AMRMClientImpl: The following two lines can fit in one.
{code}
  public Collection<T> getMatchingRequests(long
      allocationRequestId) {
{code}
# Just thinking out aloud: ResourceRequest and ContainerRequest could benefit from a builder
instead of the newInstance way. 
# This comment can be shortened, and s/aught/ought
{code}
      // send the ResourceRequest to RM even if is 0 because it needs to
      // override
      // a previously sent value. If ResourceRequest was not sent previously
      // then
      // sending 0 aught to be a no-op on RM
{code}

> Changes in AMRMClient for identifying resource-requests explicitly
> ------------------------------------------------------------------
>
>                 Key: YARN-4889
>                 URL: https://issues.apache.org/jira/browse/YARN-4889
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Arun Suresh
>         Attachments: YARN-4889.001.patch, YARN-4889.002.patch
>
>
> YARN-4879 proposes the notion of identifying allocate requests explicitly.. This JIRA
is to track the changes in AMRMClient to keep it wire compatible with the changes. Please
refer to the design doc in the parent JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message