hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4805) Don't go through all schedulers in ParameterizedTestBase
Date Thu, 25 Aug 2016 14:43:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437014#comment-15437014
] 

Arun Suresh commented on YARN-4805:
-----------------------------------

bq. In hind sight, it likely would have sufficed to automatically create this allocations
file it did not exist.
Doesn't the {{configureFairScheduler()}} method in the _ParametrizedSchedulerTestBase_ do
this already ? But yes, I agree specific tests might need specific configuration. I see that
the {{TestReservationSystem}} does a good job of configuring the FS specifically for each
test case.

bq. MockRM/RM, which might not be scheduler dependent at all..
I agree.

bq. I am okay with reverting this, and instead updating FairScheduler to create the allocations
file. We could shrink the number of tests that extend ParameterizedTests to only those that
are scheduler dependent.
Maybe as a first step, you can revert and then remove the Scheduler.FAIR from the static parameters.
We can then find a way to pass these parameters externally.

> Don't go through all schedulers in ParameterizedTestBase
> --------------------------------------------------------
>
>                 Key: YARN-4805
>                 URL: https://issues.apache.org/jira/browse/YARN-4805
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 2.9.0
>
>         Attachments: yarn-4805-1.patch
>
>
> ParameterizedSchedulerTestBase was created to make sure tests that were written with
CapacityScheduler in mind don't fail when run against FairScheduler. Before this was introduced,
tests would fail because FairScheduler requires an allocation file. 
> However, the tests that extend it take about 10 minutes per scheduler. So, instead of
running against both schedulers, we could setup the scheduler appropriately so the tests pass
against both schedulers. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message