Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 7 Jul 2016 19:58:10 +0000 (UTC)
From: "Ray Chiang (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12980530.1466256858000.51365.1467921490989@Atlassian.JIRA>
In-Reply-To: <JIRA.12980530.1466256858000@Atlassian.JIRA>
References: <JIRA.12980530.1466256858000@Atlassian.JIRA> <JIRA.12980530.1466256858315@arcas>
Subject: [jira] [Commented] (YARN-5272) FairScheduler handles "invalid"
 queue names inconsistently even after YARN-3241
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 07 Jul 2016 19:58:12 -0000


    [ https://issues.apache.org/jira/browse/YARN-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366680#comment-15366680 ] 

Ray Chiang commented on YARN-5272:
----------------------------------

Looks very nice [~wilfreds].

One debatable nit: Rather than call CharMatcher.WHITESPACE.trimFrom in two different places, abstracting it to a static utility method ( trimWhitespaceFromQueueName()? ) might prevent this sort of bug from occurring again (i.e. not changing code in all places).

> FairScheduler handles "invalid" queue names inconsistently even after YARN-3241
> -------------------------------------------------------------------------------
>
>                 Key: YARN-5272
>                 URL: https://issues.apache.org/jira/browse/YARN-5272
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.8.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>         Attachments: YARN-5272.1.patch, YARN-5272.3.patch, YARN-5272.4.patch
>
>
> The fix used in YARN-3214 uses a the JDK trim() method to remove leading and trailing spaces. The QueueMetrics uses a guava based trim when it splits the queues.
> The guava based trim uses the unicode definition of a white space which is different than the java trim as can be seen [here|https://docs.google.com/a/cloudera.com/spreadsheets/d/1kq4ECwPjHX9B8QUCTPclgsDCXYaj7T-FlT4tB5q3ahk/pub]
> A queue name with a non-breaking white space will thus still cause the same "Metrics source XXX already exists!" MetricsException.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org