Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 29 Jul 2016 09:22:20 +0000 (UTC)
From: "Sunil G (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12933154.1453406065000.167093.1469784140729@Atlassian.JIRA>
In-Reply-To: <JIRA.12933154.1453406065000@Atlassian.JIRA>
References: <JIRA.12933154.1453406065000@Atlassian.JIRA> <JIRA.12933154.1453406065869@arcas>
Subject: [jira] [Commented] (YARN-4624) NPE in PartitionQueueCapacitiesInfo
 while accessing Schduler UI
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 29 Jul 2016 09:22:22 -0000


    [ https://issues.apache.org/jira/browse/YARN-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399022#comment-15399022 ] 

Sunil G commented on YARN-4624:
-------------------------------

[~Naganarasimha Garla]. As you know, with YARN-4304 there was an improvement planned to hide {{maxAMResourcePercenatageLimit}} for parent queue. In DAO object, if we can set the variable to null, we can achieve the same. Hence we chose {{Float}} and was setting null in case of ParentQueue. With v3 patch, we also wanted to do a null check in UI to avoid the pblm mentioned in this JIRA. So couple of typecasting needed there to convert from float to Float and findbugs reported this as error. we could hide this error to have this optimization in and I was mentioning for same in earlier comments. Only concern was that, we were doing some double type casting to achieve what we are expecting. So i thought, is its really good to do something like that which is not a clean code. Hence though of going with v1 patch. Am fine either way.
Its good if we could also take input from [~leftnoteasy] [~brahmareddy] and [~bibinchundatt] too who were involved and can come to conclusion for 2.8. 

I would like to keep target version as 2.8 if its fine in either way.

> NPE in PartitionQueueCapacitiesInfo while accessing Schduler UI
> ---------------------------------------------------------------
>
>                 Key: YARN-4624
>                 URL: https://issues.apache.org/jira/browse/YARN-4624
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.8.0
>
>         Attachments: SchedulerUIWithOutLabelMapping.png, YARN-2674-002.patch, YARN-4624-003.patch, YARN-4624.patch
>
>
> Scenario:
> =======
> Configure nodelables and add to cluster
> Start the cluster
> {noformat}
> java.lang.NullPointerException
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.PartitionQueueCapacitiesInfo.getMaxAMLimitPercentage(PartitionQueueCapacitiesInfo.java:114)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$LeafQueueInfoBlock.renderQueueCapacityInfo(CapacitySchedulerPage.java:163)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$LeafQueueInfoBlock.renderLeafQueueInfoWithPartition(CapacitySchedulerPage.java:105)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$LeafQueueInfoBlock.render(CapacitySchedulerPage.java:94)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:69)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:79)
> 	at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock$Block.subView(HtmlBlock.java:43)
> 	at org.apache.hadoop.yarn.webapp.hamlet.HamletImpl$EImp._v(HamletImpl.java:117)
> 	at org.apache.hadoop.yarn.webapp.hamlet.Hamlet$LI._(Hamlet.java:7702)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$QueueBlock.render(CapacitySchedulerPage.java:293)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:69)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:79)
> 	at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock$Block.subView(HtmlBlock.java:43)
> 	at org.apache.hadoop.yarn.webapp.hamlet.HamletImpl$EImp._v(HamletImpl.java:117)
> 	at org.apache.hadoop.yarn.webapp.hamlet.Hamlet$LI._(Hamlet.java:7702)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$QueuesBlock.render(CapacitySchedulerPage.java:447)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:69)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:79)
> 	at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org