Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94FCF200B4B for ; Thu, 21 Jul 2016 08:34:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9086B160A68; Thu, 21 Jul 2016 06:34:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 089D0160A72 for ; Thu, 21 Jul 2016 08:34:21 +0200 (CEST) Received: (qmail 10012 invoked by uid 500); 21 Jul 2016 06:34:21 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 9708 invoked by uid 99); 21 Jul 2016 06:34:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2016 06:34:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9FF2B2C0D62 for ; Thu, 21 Jul 2016 06:34:20 +0000 (UTC) Date: Thu, 21 Jul 2016 06:34:20 +0000 (UTC) From: "Rohith Sharma K S (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1126) Add validation of users input nodes-states options to nodes CLI MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 21 Jul 2016 06:34:22 -0000 [ https://issues.apache.org/jira/browse/YARN-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387252#comment-15387252 ] Rohith Sharma K S commented on YARN-1126: ----------------------------------------- +1 lgtm for latest patch. I will commit it shortly. > Add validation of users input nodes-states options to nodes CLI > --------------------------------------------------------------- > > Key: YARN-1126 > URL: https://issues.apache.org/jira/browse/YARN-1126 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Wei Yan > Assignee: Wei Yan > Attachments: YARN-1126-002.patch, YARN-1126-003.patch, YARN-1126-004.patch, YARN-1126-005.patch, YARN-905-addendum.patch > > > Follow the discussion in YARN-905. > (1) case-insensitive checks for "all". > (2) validation of users input, exit with non-zero code and print all valid states when user gives an invalid state. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org